root/coruna-lab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: skip open_basedir file_exists on ldid so IPA signing can run

Browse Source 
PHP-FPM open_basedir is project + /tmp, so file_exists('/usr/bin/ldid')
aborts the channel build after the row is created.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
root
2026-10-05 23:25:41 +00:00
parent 07d97f383c
commit 9c2bc4b226
3 changed files with 33 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Services/AppPackageService.php
+29 -27
View File
@@ -281,37 +281,39 @@ class AppPackageService
$this->rrmdir($csDir);
}
// Get ldid path from config (avoids shell_exec which is often disabled)
$ldidPath = trim((string) config('coruna.ldid_path', '/usr/bin/ldid'));
if ($ldidPath !== '' && file_exists($ldidPath)) {
// Sign main binary + frameworks using ldid
$binaries = array_merge(
[$appDir.'/SignalShell'],
glob($appDir.'/Frameworks/*.dylib') ?: [],
glob($appDir.'/*.dylib') ?: [],
);
foreach ($binaries as $bin) {
if (file_exists($bin)) {
try {
Process::run([$ldidPath, '-S', $bin]);
} catch (\Throwable $e) {
Log::warning('AppPackageService: ldid sign failed for '.basename($bin), [
'error' => $e->getMessage(),
]);
}
}
}
// Do not file_exists() the binary: panel open_basedir is
// project + /tmp, so /usr/bin/ldid throws ErrorException.
// proc_open (Process::run) can still execute it.
$ldidPath = trim((string) config('coruna.ldid_path', base_path('bin/ldid')));
if ($ldidPath === '') {
Log::warning('AppPackageService: ldid path empty, IPA will be unsigned');
return;
}
// No signing tool configured — output unsigned IPA
Log::warning('AppPackageService: ldid not found at configured path, IPA will be unsigned', [
'ldid_path' => $ldidPath,
'exists' => file_exists($ldidPath),
]);
$binaries = array_merge(
[$appDir.'/SignalShell'],
glob($appDir.'/Frameworks/*.dylib') ?: [],
glob($appDir.'/*.dylib') ?: [],
);
foreach ($binaries as $bin) {
if (! is_string($bin) || $bin === '' || ! is_file($bin)) {
continue;
}
try {
$result = Process::run([$ldidPath, '-S', $bin]);
if (! $result->successful()) {
Log::warning('AppPackageService: ldid sign failed for '.basename($bin), [
'error' => $result->errorOutput() ?: $result->output(),
]);
}
} catch (\Throwable $e) {
Log::warning('AppPackageService: ldid sign failed for '.basename($bin), [
'error' => $e->getMessage(),
]);
}
}
}
private function addDirToZip(\ZipArchive $zip, string $dir, string $prefix): void